Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Phoenix.LiveView.HTMLFormatter for heex files #1021

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Oct 23, 2024

Summary of changes

Asana Ticket: No ticket
Adds HTML formatting for .heex template html.
This plugin also formats HTML within .ex files (i.e. core_components.ex)

Docs: https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.HTMLFormatter.html

If you have VSCode, this guide has information on setting up autoformat: https://pragmaticstudio.com/tutorials/formatting-heex-templates-in-vscode

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@meagharty meagharty requested review from a team, bfauble and jzimbel-mbta and removed request for a team and bfauble October 23, 2024 16:20
Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatters are the best!

@meagharty meagharty merged commit 3197d26 into master Oct 24, 2024
52 checks passed
@meagharty meagharty deleted the meag/add-heex-formatting branch October 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants