Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update shuttle_live to assign initial shuttle for validate call, update seeds for FK duplication #1034

Merged
merged 5 commits into from
Nov 7, 2024
Merged

fix: update shuttle_live to assign initial shuttle for validate call, update seeds for FK duplication #1034

merged 5 commits into from
Nov 7, 2024

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Nov 6, 2024 •
edited
Loading

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@meagharty meagharty changed the title Meag/lem shuttle route page liveview fix: update shuttle_live to assign initial shuttle for validate call, update seeds for FK duplication Nov 6, 2024
@meagharty meagharty marked this pull request as ready for review November 6, 2024 20:33
lemald
lemald approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@lemald lemald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor and very optional syntax nitpicks, but otherwise looks good!

@meagharty meagharty merged commit 0039bdb into lem-shuttle-route-page-liveview Nov 7, 2024
10 checks passed
@meagharty meagharty deleted the meag/lem-shuttle-route-page-liveview branch November 7, 2024 19:05
lemald added a commit that referenced this pull request Nov 7, 2024
@lemald @meagharty
Make shuttle route page use LiveView (#1033)
c48ea51 
* chore: migration to separate out foreign keys

* fix: get seeds.exs working with schema changes

* chore: various small schema updates

* refactor: migrate shuttle page to LiveView

* test: test for shuttle route LiveView

* refactor: make use of helper functions in Arrow.Shuttles for changes

* fixup! refactor: make use of helper functions in Arrow.Shuttles for changes

* refactor: rename erroneous references to shuttle_route

* refactor: remove unneeded on_replace: :delete

* fix: update shuttle_live to assign initial shuttle for validate call, update seeds for FK duplication (#1034)


---------

Co-authored-by: Eddie Maldonado <[email protected]>

---------

Co-authored-by: meagharty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemald lemald lemald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meagharty @lemald