-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logout with ueberauth_oidcc #950
Conversation
8de499e
to
ffbeee5
Compare
ffbeee5
to
c26e187
Compare
c26e187
to
44f51bf
Compare
44f51bf
to
c975990
Compare
f5bfba2
to
e3fcae3
Compare
e3fcae3
to
ed9a745
Compare
ed9a745
to
5fc14e5
Compare
600e72e
to
bf32351
Compare
bf32351
to
b6c8f91
Compare
ef43b74
to
cbdbc2a
Compare
cbdbc2a
to
d52669e
Compare
d52669e
to
3e547cc
Compare
de64aeb
to
34a959b
Compare
34a959b
to
c6dc33c
Compare
c6dc33c
to
bd27bc9
Compare
bd27bc9
to
d9d6154
Compare
d9d6154
to
effdd92
Compare
effdd92
to
1f4ce23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good to me, just a couple non-blocking q's 😄
ArrowWeb.AuthManager, | ||
auth_token.username, | ||
%{roles: roles}, | ||
ttl: {0, :second} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this provide a session that never expires?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opposite; it expires immediately so that if it does happen to make it outside of the API (which it shouldn't) it won't be usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be a session that expires immediately, but I will double-check that's how Guardian treats it (or if there's another way to implement this).
The issue I ran into (and I think this is true of the existing implementation) is that the API returned a session cookie that you can use instead of the API key, and I didn't think that was the normal approach for an API. We disable that now, but also set a 0-second TTL to ensure that if the token did leak out, it wouldn't be usable.
1f4ce23
to
372c279
Compare
Coverage of commit
|
Summary of changes
Support logging out based on the
Ueberauth.Strategy.Oidcc
strategy, and API access via the Keycloak API. Based on top of #952 .Reviewer Checklist