Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-admins can fetch their token and use GET apis #962

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Feb 8, 2024

Summary of changes

Asana Ticket: 💳 Fix Dependabot CI on gtfs_creator

Related to #963 in that we need the GET APIs to support non-admin users for dependabot

Partly based on #930 with other updates since then.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

Copy link

github-actions bot commented Feb 8, 2024

Coverage of commit f512215

Summary coverage rate:
  lines......: 88.8% (672 of 757 lines)
  functions..: 59.2% (515 of 870 functions)
  branches...: no data found

Files changed coverage rate:
                                                                     |Lines       |Functions  |Branches    
  Filename                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================
  lib/arrow/permissions.ex                                           |75.0%      4| 100%     3|    -      0
  lib/arrow_web/controllers/api/db_dump_controller.ex                | 100%      3| 100%     6|    -      0
  lib/arrow_web/controllers/api/notice_controller.ex                 | 100%      8| 100%     6|    -      0
  lib/arrow_web/controllers/my_token_controller.ex                   | 100%      4| 100%     6|    -      0
  lib/arrow_web/router.ex                                            |95.0%     20|43.8%    73|    -      0

Download coverage report

@meagharty meagharty marked this pull request as ready for review February 8, 2024 13:23
@meagharty meagharty requested a review from bklebe February 8, 2024 13:25
@meagharty meagharty force-pushed the meag/dont-require-admin-privs-GET-api-and-token branch from f512215 to bd1c055 Compare February 8, 2024 22:49
Copy link

github-actions bot commented Feb 8, 2024

Coverage of commit bd1c055

Summary coverage rate:
  lines......: 88.8% (672 of 757 lines)
  functions..: 59.2% (515 of 870 functions)
  branches...: no data found

Files changed coverage rate:
                                                                     |Lines       |Functions  |Branches    
  Filename                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================
  lib/arrow/permissions.ex                                           |75.0%      4| 100%     3|    -      0
  lib/arrow_web/controllers/api/db_dump_controller.ex                | 100%      3| 100%     6|    -      0
  lib/arrow_web/controllers/api/notice_controller.ex                 | 100%      8| 100%     6|    -      0
  lib/arrow_web/controllers/my_token_controller.ex                   | 100%      4| 100%     6|    -      0
  lib/arrow_web/router.ex                                            |95.0%     20|43.8%    73|    -      0

Download coverage report

@meagharty meagharty merged commit 40f4ff2 into master Feb 9, 2024
16 checks passed
@meagharty meagharty deleted the meag/dont-require-admin-privs-GET-api-and-token branch February 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants