Increase coverage and consistency of trip planner tests #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
commented
Jan 17, 2025
| @@ -265,7 +265,7 @@ defmodule DotcomWeb.Router do | |||
|
|
|||
| scope "/preview", DotcomWeb do | |||
| import Phoenix.LiveView.Router | |||
| pipe_through([:browser, :browser_live, :basic_auth_readonly]) | |||
| pipe_through([:browser, :browser_live]) | |||
There was a problem hiding this comment.
📓 Just did this for convenience since basic auth won't be there in the near future. Will remove this from the PR before merge.
anthonyshull
commented
Jan 17, 2025
| @@ -4,401 +4,249 @@ defmodule DotcomWeb.Live.TripPlannerTest do | |||
| import Mox | |||
There was a problem hiding this comment.
📓 Rather than looking at the diff, I would review the file in its entirety since I completely rewrote it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket. I went through the Trip Planner and wrote tests for everything I think we should cover. Tests are focused on behavior and allow appearance testing to be done in the components.