feat(iOS): Combined stop details VoiceOver pass #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Combined Stop + Trip Details: VoiceOver pass
Update the combined stop details page to have functional voiceover behavior.
iOS
android
- [ ] All user-facing strings added to strings resource- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Testing accessibility modifiers is unfortunately poorly supported, the only things we can really test are labels and hints, so I added some tests for those. We're unable to unit test the announcements, headers, or traits. I did do fairly extensive manual testing though.