Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android.NearbyTransitPage): navigation refactor to support trip filter #653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(android.NearbyTransitPage): navigation refactor to support trip filter #653

wants to merge 2 commits into from

Conversation

KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Jan 15, 2025 •
edited
Loading

Summary

Ticket: 🤖 | stop + trip details | barebones UX

What is this PR for?

This is a first step in getting the barebones UX trip details.

  1. Rename filter => stopFilter and add tripFilter
  2. Rework navigation to pass around SheetRoute instead of NavBackStackEntry. This made it easier to read the filters that are set on the stop details pages.
  3. Copy setStopFilter logic from iOS.
    iOS
  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

What testing have you done?

  • Added unit tests
  • Ran locally and confirmed navigation between nearby transit & stop details still works as expected
    • Note: the back button now works as a close button since on iOS there is no longer a back button on stop details.

@KaylaBrady KaylaBrady requested a review from a team as a code owner January 15, 2025 14:23
@KaylaBrady KaylaBrady requested a review from BrandonTR January 15, 2025 14:23
BrandonTR
BrandonTR approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@BrandonTR BrandonTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question

...idApp/src/main/java/com/mbta/tid/mbta_app/android/nearbyTransit/NearbyTransitTabViewModel.kt
}

fun setStopDetailsDepartures(departures: StopDetailsDepartures?) {
_stopDetailsDepartures.value = departures
}

// TODO: Move these to separate Navigation utils helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something you meant to do or something we should revisit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I had meant to do this as part of this PR, but may leave it in place for now until I port over more of the navigation logic and see how it all fits together.

@KaylaBrady KaylaBrady force-pushed the kb-android-trip-details-barebones branch from 17d504c to 08171ca Compare January 17, 2025 17:08
@KaylaBrady KaylaBrady mentioned this pull request Jan 17, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonTR BrandonTR BrandonTR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaylaBrady @BrandonTR