refactor: move analytics abstractions to shared #658
Merged
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
succeeded
Jan 17, 2025 in 32m 20s
60 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 60 |
Details
60 Warnings
Details
iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:134
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Using '_' to ignore the result of a Void-returning function is redundant
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Expression implicitly coerced from 'URLResponse?' to 'Any'
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
File Length Violation: File should contain 400 lines or less: currently contains 409 (file_length)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
File Length Violation: File should contain 400 lines or less: currently contains 563 (file_length)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 308 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 315 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 180 characters (line_length)
Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
File Length Violation: File should contain 400 lines or less: currently contains 498 (file_length)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Line Length Violation: Line should be 120 characters or less; currently it has 175 characters (line_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Annotations
Check notice on line 230 in iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilteredRouteView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilteredRouteView.swift#L230
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Check notice on line 409 in iosApp/iosApp/ContentView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ContentView.swift#L409
File Length Violation: File should contain 400 lines or less: currently contains 409 (file_length)
Check notice on line 127 in iosApp/iosApp/ViewModels/SearchViewModel.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ViewModels/SearchViewModel.swift#L127
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Check notice on line 95 in iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift#L95
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Check notice on line 114 in iosApp/iosApp/Pages/StopDetails/TripDetailsView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/StopDetails/TripDetailsView.swift#L114
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Check notice on line 563 in iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift#L563
File Length Violation: File should contain 400 lines or less: currently contains 563 (file_length)
Check notice on line 14 in iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift#L14
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 308 lines (type_body_length)
Check notice on line 372 in iosApp/iosApp/ContentView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ContentView.swift#L372
Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Check notice on line 16 in iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift#L16
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 315 lines (type_body_length)
Check notice on line 69 in iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift#L69
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Loading