Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StopDetailsPage): Support trip filtering #663

Draft
wants to merge 3 commits into
base: kb-stop-details-vm
Choose a base branch
from

Conversation

KaylaBrady
Copy link
Collaborator

Summary

Ticket: 🤖 | stop + trip details | barebones UX

What is this PR for?
Adds trip filtering to the stop details page using existing departure list styling.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

What testing have you done?

  • Added a border around the selected trip, confirmed the first trip is automatically selected & manually selected trip is preserved
  • TODO: Add unit tests

@KaylaBrady KaylaBrady force-pushed the kb-android-trip-details-barebones-2 branch from 7a94160 to a805047 Compare January 17, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant