Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix coloring of NavLinks inside NavBar #968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Jan 23, 2025

Description

With the latest Bootstrap theme, the NavLinks inside our NavBars were incorrectly colored. However, this is actually not an issue of the Bootstrap theme, as the CSS itself is correct.

The issue appears as with the usage of dbc.NavBar, the className ="navbar-light" is automatically attached to that component in both dark and light theme. We could probably fix this via callbacks, but I think the CSS fix is fine.

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-01-23 17:42:40 UTC
Commit: 4087b9e

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen changed the title Fix coloring [Bug] Fix coloring of NavLinks inside NavBar Jan 23, 2025
@huong-li-nguyen huong-li-nguyen self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant