Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Document member support notes for Firefox #25617

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 9, 2025

Summary

For every Document member that, in some Firefox versions, is only exposed to HTMLDocument (and not also to SVGDocument and XMLDocument), ensures that there is a corresponding note.

Test results and supporting details

Source: https://github.com/caugner/document-members/blob/main/SUMMARY.md#firefox

Related issues

Part of #10682.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:l [PR only] 101-1000 LoC changed labels Jan 9, 2025
caugner

This comment was marked as outdated.

@caugner caugner marked this pull request as draft January 9, 2025 17:20
@caugner caugner changed the title Add Document member support notes for Firefox Add Document member support notes for Chrome + Firefox Jan 9, 2025
@caugner caugner force-pushed the 10682-add-document-member-notes branch from 201af1e to e8a5477 Compare January 9, 2025 17:51
@caugner caugner force-pushed the 10682-add-document-member-notes branch from e8a5477 to 3e054cd Compare January 9, 2025 17:52
@caugner caugner changed the title Add Document member support notes for Chrome + Firefox Add Document member support notes for Firefox Jan 9, 2025
@caugner caugner marked this pull request as ready for review January 9, 2025 17:53
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flat, ungrouped diff:

image
[^n1]: "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects."
[^n5]: "Before Firefox 68, `cookie` was available only on HTML documents; it is now available on all documents, such as XML and SVG."
[^n15]: "From Firefox 62, if the domain cannot be identified, `domain` returns an empty string instead of `null`. See [bug 819475](https://bugzil.la/819475)."
[^n21]: "From Firefox 82, nested calls are not supported (return `false`). See [bug 1634262](https://bugzil.la/1634262)."
[^n22]: "Before Firefox 89, manipulating the content of `<input>` and `<textarea>` elements using `Document.execCommand()` commands requires workarounds (see [bug 1220696](https://bugzil.la/1220696))."
[^n30]: "`queryCommandEnabled` with arguments `cut`, `copy` or `paste` would throw errors unless the script had special privileges."
[^n31]: "The `\"paste\"` command is reported as supported when the paste feature is available even if the calling script has insufficient privileges to actually perform the action."

@caugner caugner requested a review from Elchi3 January 10, 2025 13:21
@Elchi3
Copy link
Member

Elchi3 commented Jan 10, 2025

Test results and supporting details

Source: https://github.com/caugner/document-members/blob/main/SUMMARY.md#firefox

This repo 404s. Maybe it is private?

@caugner
Copy link
Contributor Author

caugner commented Jan 10, 2025

This repo 404s. Maybe it is private?

Apologies, it should be public now.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like pretty solid research to me. Let's land this and the other PRs.
Great work! 👍

@Elchi3 Elchi3 merged commit a87dc17 into main Jan 10, 2025
11 checks passed
@Elchi3 Elchi3 deleted the 10682-add-document-member-notes branch January 10, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants