fix: Better element ID naming for disambiguation (fixes mdn/web-components-examples#74)

[ngdangtu-vn]

Description

This is the sibling PR with mdn/web-components-examples#77

Motivation

To match the web-components-examples example.

Additional details

none

Related issues and pull requests

• Fixes Improve readability for 'simple-template' example web-components-examples#74
• Relates to fix: Better element ID naming for disambiguation (fixes #74) web-components-examples#77
• Depends on: #123

[github-actions]

Preview URLs

• /en-US/docs/Web/API/CustomElementRegistry/getName
• /en-US/docs/Web/API/CustomElementRegistry/get
• /en-US/docs/Web/API/Web_components/Using_templates_and_slots

(comment last updated: 2024-06-22 08:37:31)

[ngdangtu-vn]

Hi @bsmth , I've updated the MDN doc example. Please take a look.

[bsmth]

Thanks @ngdangtu-vn - sorry for the delay, I've been away and could not take a look. I've added myself as a reviewer now!

[bsmth]

Thanks a lot! There's one leftover line to fix, but then we're ready to merge and the accompanying PR, too.

[bsmth]

See comment about L65 in files/en-us/web/api/web_components/using_templates_and_slots/index.md

[bsmth]

Hey @ngdangtu-vn - thanks for your suggestions! Quick reminder there's one last thing to get on this branch and we're ready to go!

[bsmth]

@ngdangtu-vn - is it okay with you if I make the changes on your branch and merge?

[ngdangtu-vn]

@bsmth Sorry for later response, I think the the notification got lost somewhere. Hopefull it didn't pulling your task down too much.

[bsmth]

Super, looking good!

[bsmth]

@bsmth Sorry for later response, I think the the notification got lost somewhere. Hopefull it didn't pulling your task down too much.

Not a problem, well done on your contribution!

[ngdangtu-vn]

@ngdangtu-vn - is it okay with you if I make the changes on your branch and merge?

I don't mind at all. If it's convenience for you, please go ahead.

Edit, I think something weird with gh notification, it has quite amount of time in delay...