Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Add 'Learn_web_development' slugs for front matter linter #36981

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 26, 2024

Description

Front matter linting looks like it uses main config instead of the branch because of execution context (even though front-matter-config.json is changed on the PR branch).

For a Learn area move, I would add a new slug entry Learn_web_development to main so that CI uses this config.

When the Learn area move is done, we can remove the ^Learn/ path from checks.

Motivation

Fixing failing CI in https://github.com/mdn/content/actions/runs/12027470524

@bsmth bsmth requested a review from a team as a code owner November 26, 2024 10:01
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Nov 26, 2024
@OnkarRuikar
Copy link
Contributor

The changes look good.

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@bsmth
Copy link
Member Author

bsmth commented Nov 27, 2024

Thanks, both!

@bsmth bsmth merged commit 65b49f2 into mdn:main Nov 27, 2024
7 checks passed
@bsmth bsmth deleted the front-matter-linter-learn branch November 27, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants