Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax for svg <pattern> element #36994

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

Description

for svg <pattern> element, height width x y only accept a <length> value

also update svg data for svg <pattern> element (for element list and attribute list)

and some style adjust to documentations

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 27, 2024 01:43
@skyclouds2001 skyclouds2001 requested review from a team as code owners November 27, 2024 01:43
@skyclouds2001 skyclouds2001 requested review from hamishwillee and bsmth and removed request for a team November 27, 2024 01:43
@github-actions github-actions bot added Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024


## pattern
## Elements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@bsmth bsmth merged commit 98af854 into mdn:main Dec 4, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the svg-pattern branch December 4, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants