Reference for stage 3 temporal #37344

Josh-Cena · 2024-12-23T06:12:53Z

~~Far from ready for review, and I'll work on this alone for a while~~

It is now ready for review! It's extremely big but I think it's more worthwhile getting it in as a whole. I`m already leaving the guide to a second PR.

For reviewers (both editorial and technical): I've made a spreadsheet here: https://docs.google.com/spreadsheets/d/1RrRHL0m08R4V4WtuWBbSWr9a1gO4RiIaH42WrPv_Uhs/edit Welcoming anyone on the team for editorial reviews! Technical review from the champion group is greatly appreciated too. It seems we have roughly 4 weeks to make this happen.

github-actions · 2024-12-23T06:15:11Z

Preview URLs (282 pages)

External URLs (41)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON
Title: JSON

https://datatracker.ietf.org/doc/html/rfc8259 (1 time)
https://en.wikipedia.org/wiki/Augmented_Backus%E2%80%93Naur_form (1 time)
https://en.wikipedia.org/wiki/YAML (1 time)
https://github.com/tc39/proposal-json-superset (1 time)
https://json-diff.com/ (1 time)
https://json.org/ (1 time)
https://json5.org/ (1 time)
https://jsonbeautifier.org/ (1 time)
https://jsonparser.org/ (1 time)
https://tools.learningcontainer.com/json-validator/ (1 time)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal
Title: Temporal

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDate
Title: Temporal.PlainDate

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDate/day
Title: Temporal.PlainDate.prototype.day

https://en.wikipedia.org/wiki/Adoption_of_the_Gregorian_calendar (1 time) (Note! This may be a new URL 👀)
https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/Instant
Title: Temporal.Instant

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainYearMonth
Title: Temporal.PlainYearMonth

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime
Title: Temporal.ZonedDateTime

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)
https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-bcp47/bcp47/timezone.json (2 times) (Note! This may be a new URL 👀)
https://unicode.org/reports/tr35/ (1 time) (Note! This may be a new URL 👀)
https://www.iana.org/time-zones (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/day
Title: Temporal.ZonedDateTime.prototype.day

https://en.wikipedia.org/wiki/Time_in_Samoa (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/add
Title: Temporal.ZonedDateTime.prototype.add()

https://datatracker.ietf.org/doc/html/rfc5545 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/ZonedDateTime/since
Title: Temporal.ZonedDateTime.prototype.since()

https://datatracker.ietf.org/doc/html/rfc5545 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDateTime
Title: Temporal.PlainDateTime

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainMonthDay
Title: Temporal.PlainMonthDay

https://datatracker.ietf.org/doc/html/rfc3339 (1 time) (Note! This may be a new URL 👀)
https://datatracker.ietf.org/doc/html/rfc9557 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/Duration
Title: Temporal.Duration

<https://en.wikipedi…

TRUNCATED!

github-actions · 2025-01-14T17:21:24Z

This pull request has merge conflicts that must be resolved before it can be merged.

.../en-us/web/javascript/reference/global_objects/temporal/plainmonthday/plainmonthday/index.md

bsmth

Couple of comments for Conversion group, nearly there

...s/en-us/web/javascript/reference/global_objects/temporal/instant/tozoneddatetimeiso/index.md

...n-us/web/javascript/reference/global_objects/temporal/plaindatetime/tozoneddatetime/index.md

...n-us/web/javascript/reference/global_objects/temporal/zoneddatetime/toplaindatetime/index.md

files/en-us/web/javascript/reference/global_objects/temporal/zoneddatetime/toplaintime/index.md

github-actions · 2025-01-16T01:33:48Z

This pull request has merge conflicts that must be resolved before it can be merged.

bsmth

Minor comments in Serialization group

files/en-us/web/javascript/reference/global_objects/temporal/instant/tolocalestring/index.md

files/en-us/web/javascript/reference/global_objects/temporal/instant/valueof/index.md

files/en-us/web/javascript/reference/global_objects/temporal/plainyearmonth/tojson/index.md

bsmth

Last ones on Temporal.Duration

files/en-us/web/javascript/reference/global_objects/temporal/duration/compare/index.md

files/en-us/web/javascript/reference/global_objects/temporal/duration/days/index.md

files/en-us/web/javascript/reference/global_objects/temporal/duration/years/index.md

bsmth

Amazing work. Some comments for you to check, but I'm more than happy to leave a +1, well done 👏🏻

Josh-Cena · 2025-01-16T20:01:08Z

I plan to merge it some time next week, because I currently have another PR that depends on the Intl changes, and I also need to work on the guide. People are encouraged to leave comments as early as possible, but we can definitely accept follow-up PRs, preferably for bug fixes, especially from the champion group.

files/en-us/web/javascript/reference/global_objects/date/totemporalinstant/index.md

Josh-Cena · 2025-01-20T17:38:37Z

@printfn Done, thanks for pointing out! I plan to merge it today, so if you have or don't have more comments please feel free to send them.

Josh-Cena · 2025-01-20T22:27:37Z

I'm going to go ahead and merge it. Thanks everyone! I understand that this is not the final version, and we will surely continue to iterate on it.

justingrant · 2025-01-22T04:38:04Z

Thanks so much @Josh-Cena for making this happen!

Also grateful for @meyerweb for all the work you did on the docs previously, and in helping to review this PR.

Developers worldwide are going to be thankful. 🙏

Reference for stage 3 temporal

27a3784

github-actions bot added Content:JS JavaScript docs size/xl [PR only] >1000 LoC changed labels Dec 23, 2024

More description

a477fa3

Josh-Cena mentioned this pull request Dec 25, 2024

What's the plan to get Temporal docs into MDN? tc39/proposal-temporal#1449

Open

Josh-Cena added 16 commits December 25, 2024 21:28

Duration docs

9f50952

Fix link

bd0796c

Complete Duration docs

fbd0601

Instant docs

6ab2afd

Now docs

ef79211

TZ and calendar docs

02295b7

PlainDate docs

0936403

Change ISO format description

889b358

ZonedDateTime-specific stuff docs

7ca2b31

PlainMonthDay docs, copy date-related fields to PlainDateTime

7d9cdfe

PlainYearMonth docs

a0ab015

PlainTime docs

f4342cf

Intl docs

4974d24

PlainDateTime docs

0a172b6

ZonedDateTime docs, easy part

ac18c5f

ZonedDateTime docs... and that shall be all

ac298ef

Josh-Cena mentioned this pull request Jan 3, 2025

feat(sidebars/jsref): support temporal mdn/rari#72

Merged

Simplifications and fixes

f385d12

Josh-Cena force-pushed the temporal branch from 7daf469 to f385d12 Compare January 3, 2025 09:04

Josh-Cena marked this pull request as ready for review January 3, 2025 09:04

Josh-Cena requested a review from a team as a code owner January 3, 2025 09:04

Josh-Cena requested review from chrisdavidmills and hamishwillee and removed request for a team January 3, 2025 09:04

github-actions bot added the merge conflicts 🚧 [PR only] label Jan 14, 2025

Merge branch 'main' into temporal

627cdeb

github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 14, 2025

Josh-Cena commented Jan 14, 2025

View reviewed changes

.../en-us/web/javascript/reference/global_objects/temporal/plainmonthday/plainmonthday/index.md Outdated Show resolved Hide resolved

Josh-Cena added 3 commits January 14, 2025 14:06

Update index.md

bf72961

Update index.md

0ca21c0

Update index.md

25e1bb1

bsmth reviewed Jan 15, 2025

View reviewed changes

github-actions bot added the merge conflicts 🚧 [PR only] label Jan 16, 2025

Merge branch 'main' into temporal

aa9c790

github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 16, 2025

Reviews, some (?) conversion methods

4b68919

bsmth reviewed Jan 16, 2025

View reviewed changes

bsmth approved these changes Jan 16, 2025

View reviewed changes

Last group of reviews

1a21ed6

This was referenced Jan 20, 2025

Add missing Temporal spec_url entries mdn/browser-compat-data#25714

Merged

Rename Temporal timeZoneID -> timeZoneId, typo mdn/browser-compat-data#25715

Merged

Add Date.toTemporalInstant mdn/browser-compat-data#25716

Merged

printfn reviewed Jan 20, 2025

View reviewed changes

files/en-us/web/javascript/reference/global_objects/date/totemporalinstant/index.md Show resolved Hide resolved

Mention toTemporalInstant RangeError

3fd90b9

Josh-Cena changed the title ~~[new-ci] Reference for stage 3 temporal~~ Reference for stage 3 temporal Jan 20, 2025

Josh-Cena merged commit a4e9bce into mdn:main Jan 20, 2025
9 checks passed

Josh-Cena deleted the temporal branch January 20, 2025 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reference for stage 3 temporal #37344

Reference for stage 3 temporal #37344

Josh-Cena commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Jan 14, 2025

bsmth left a comment

github-actions bot commented Jan 16, 2025

bsmth left a comment

bsmth left a comment

bsmth left a comment

Josh-Cena commented Jan 16, 2025

Josh-Cena commented Jan 20, 2025

Josh-Cena commented Jan 20, 2025

justingrant commented Jan 22, 2025

Reference for stage 3 temporal #37344

Reference for stage 3 temporal #37344

Conversation

Josh-Cena commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Jan 14, 2025

bsmth left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025

bsmth left a comment

Choose a reason for hiding this comment

bsmth left a comment

Choose a reason for hiding this comment

bsmth left a comment

Choose a reason for hiding this comment

Josh-Cena commented Jan 16, 2025

Josh-Cena commented Jan 20, 2025

Josh-Cena commented Jan 20, 2025

justingrant commented Jan 22, 2025

Josh-Cena commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading