chore(workflows/pr-test): run rari alongside legacy #37766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
system
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use variables to control which tests to run.
caugner
commented
Jan 23, 2025
Introduces TEST_UPLOAD_LEGACY variable, currently set to true.
|
Thanks, I'll merge in about 1h (approximately 12.15pm UTC). |
|
Unfortunately, I missed the important details that repository variables aren't passed to workflows triggered by pull requests in forks, so it now runs with rari by default. |
caugner
added a commit
that referenced
this pull request
Jan 23, 2025
Variables are not passed to worfklows that are triggered by a pull request from a fork, so #37766 did not work as intended, and rari is always used for tests. To mitigate this, we extract a new legacy test workflow, that we can disable, or re-enable in case fo rari issues.
caugner
added a commit
that referenced
this pull request
Jan 23, 2025
Variables are not passed to workflows that are triggered by a pull request from a fork, so #37766 did not work as intended, and rari is always used for tests. To mitigate this, we extract a new legacy test workflow, that we can disable, or re-enable in case fo rari issues.
caugner
added a commit
that referenced
this pull request
Jan 23, 2025
Variables are not passed to workflows that are triggered by a pull request from a fork, so #37766 did not work as intended, and rari is always used for tests. To mitigate this, we extract a new legacy test workflow, that we can disable, or re-enable in case of rari issues.
caugner
added a commit
that referenced
this pull request
Jan 23, 2025
Variables are not passed to workflows that are triggered by a pull request from a fork, so #37766 did not work as intended, and rari is always used for tests. To mitigate this, we extract a new legacy test workflow, that we can disable, or re-enable in case of rari issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
pr-test-new-ci.ymlintopr-test.yml, creating two jobs:legacy(without rari), which is run ifvars.TEST_LEGACY == 'true'tests(with rari), which is run unlessvars.TEST_SKIP_RARI == 'true'Which job results are uploaded as artifacts depends on
vars.TEST_LEGACYandvars.TEST_UPLOAD_LEGACY. If both are'true', then the legacy test results are uploaded, otherwise the rari test results.Note: These are repository variables, currently set as follows:
Motivation
Allows us to roll out rari to all PRs, and to disable it temporarily if any issues come up.
Additional details
Part of MP-1851.
Related issues and pull requests
Related PRs: