Draft: feat: alias support prefix #442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 95.73% 95.70% -0.03%
==========================================
Files 44 44
Lines 6278 6282 +4
==========================================
+ Hits 6010 6012 +2
- Misses 268 270 +2 ☔ View full report in Codecov by Sentry. |
bbtfr
force-pushed
the
liyang/alias-prefix
branch
from
d338461 to
4fe2cb3
Compare
LoveEatCandy
reviewed
Dec 9, 2024
| protocol = aliases[protocol]["protocol"] | ||
| path = "%s://%s" % (protocol, path_without_protocol) | ||
| path = "%s://%s%s" % (protocol, prefix, path_without_protocol) |
There was a problem hiding this comment.
感觉这个 prefix 可能会引发客服问题，用户可能不知道后面留几个斜杠，不同的协议可能还不一样，比如有人填的是 sftp://ubuntu@host ，正确的应该填 sftp://ubuntu@host// 吧，还有相对路径和绝对路径不知道有没有影响，🤣
There was a problem hiding this comment.
我自己写也容易写错，但感觉这个并不是 alias 引发的，是 sftp 咱可能定义的太奇怪了
偷偷帮用户补一个 / 感觉也容易有坑，所以我就 bypass 直接传了
你觉得这里应该用 join 吗？比如没写 / 自动补一个？
- sftp://ubuntu@host = sftp://ubuntu@host/
- sftp://ubuntu@host/ = sftp://ubuntu@host/
- sftp://ubuntu@host// = sftp://ubuntu@host//
There was a problem hiding this comment.
搞个 sftp config 文件会不会好点
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持一下在 alias 里写 prefix，方便给一些常用的 sftp host 加个 alias