-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TaskClient
, BatchClient
, associated types, and settings types
#1825
Draft
flevi29
wants to merge
17
commits into
meilisearch:main
Choose a base branch
from
flevi29:improve-task-batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flevi29
added
enhancement
New feature or request
breaking-change
The related changes are breaking for the users
labels
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
- Coverage 98.21% 97.68% -0.53%
==========================================
Files 17 18 +1
Lines 1565 1470 -95
Branches 333 285 -48
==========================================
- Hits 1537 1436 -101
- Misses 28 34 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
The related changes are breaking for the users
bug
Something isn't working
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Batch
,EnqueuedTask
andTask
Date
objects, but this functionality is also being removed, because:meilisearch
Rust source codeEnqueuedTaskObject
toEnqueuedTask
canceledBy
property as it doesn't existindexUid
property cannot beundefined
but can benull
BatchObject
toBatch
, adjust propertiesTaskObject
toTask
, adjust propertiesTask.details
had quite a few properties missing, likepagination
, now it's reusing theSettings
type, so we don't repeat ourselvesSettings
typesTaskClient
setInterval
getTask
requests sent until the previous one finishes (less spam, more efficient)EnqueuedTask
object as parameterwaitForTasks
can now accept an iterable instead of just an array as parameterwaitForTasksIter
, which is an asynchronous generator, that lazily awaits the tasksPromise<EnqueuedTask>
now instead returns anEnqueuedTaskPromise
Promise<EnqueuedTask>
with an extra methodwaitTask
, that first gets theEnqueuedTask
and then internally callsTaskClient.waitForTask
on it to return aPromise<Task>
, avoiding quite a bit of boilerplateWaiting on #1741 ...
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
TODO: also create a new issue regarding testing and auto generating code samples