add devtools options to break on data errors with GDB connected + flag to access full 8mb main memory in DS mode #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiekierka
reviewed
Nov 17, 2024
| @@ -469,6 +469,8 @@ class NDS | |||
| virtual void ARM7IOWrite16(u32 addr, u16 val); | |||
| virtual void ARM7IOWrite32(u32 addr, u32 val); | |||
|
|
|||
| void SetMemoryExtension(bool enabled); | |||
There was a problem hiding this comment.
Could this flag be extended to also work on TWL/DSi? Its debug units have 32MB of RAM as opposed to 16MB of RAM; it's available at 0xC000000 ~ 0xDFFFFFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these useful when I was debugging issues with a ROM which uses more than 4mb memory under specific optimization levels (at higher optimization levels it fits fine, but with optimizations disabled it needs more than 4mb total).
BreakOnErrorflag can help to track down errors related to memory access/allocationDebug.ExtendedMemoryflag allows access to the full 8mb main memory range, instead of mirroring the lower 4mb to the upper 4mbno retail DS provides access to the upper 4mb, but per gbatek there were hardware debugger machines which can use the full 8mb. this PR does not implement everything covered by the debugger machine, only allows access to more memory for debugging purposes. this does mean that the behaviour of the emulator with the 8mb flag enabled is a bit far from retail.