Stop ignoring timestamps #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
mat-hek
requested changes
Mar 5, 2024
lib/membrane_sdl/player.ex
Outdated
| def handle_stream_format(:input, stream_format, ctx, state) do | ||
| %{input: input} = ctx.pads | ||
| %{cnode: cnode} = state | ||
|
|
||
| if !input.stream_format || stream_format == input.stream_format do | ||
| def handle_stream_format(:input, stream_format, ctx, %{cnode: cnode} = state) do | ||
| if !ctx.pads.input.stream_format || stream_format == ctx.pads.input.stream_format do |
lib/membrane_sdl/player.ex
Outdated
Comment on lines
54
to
60
| %{last_pts: nil, last_payload: nil} -> | ||
| [demand: :input] | ||
|
|
||
| %{last_pts: last_pts, last_payload: last_payload} -> | ||
| :ok = CNode.call(state.cnode, :display_frame, [last_payload]) | ||
|
|
||
| [timer_interval: {:demand_timer, pts - last_pts}] |
There was a problem hiding this comment.
- when we get the first frame, we should display it immediately
- when we get a subsequent frame, we should display it in
handle_tick
so it looks like it should be the other way round
mat-hek
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.