-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown decoder #191
base: master
Are you sure you want to change the base?
Markdown decoder #191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
+ Coverage 90.63% 91.04% +0.4%
=========================================
Files 12 12
Lines 1089 1172 +83
=========================================
+ Hits 987 1067 +80
- Misses 102 105 +3
Continue to review full report at Codecov.
|
@pulyaevskiy Any chance this can start to get reviewed We are using zefyr heavily for our project and want to help get the Markdown encode and decode cycle working and so hoping a base approach like this can get mainlined so that we are others can contribute |
@pulyaevskiy Also there are forked now way ahead of Master. https://github.com/memspace/zefyr/network Such as:
sort of worried this is going to splinter. |
I'll just throw in my hat and say that I'd much appreciate this PR getting merged as well |
Would be amazing to have md support 🎉 👏 |
@nalbion does it already handle images? can't get them to work using your fork locally |
Please review this change !! .. It will be great to have MD support on this editor |
I would love to see this PR merged. I tried to use this with this md:
but I get this error: |
If I added your changes to a forked version of notus, how would I go about getting the zefyr to detect when you input the markdown text? |
When can we expect this? its stopping me from implementing zefyr in my app. |
Hi @nalbion you can only nest headers and inline styles inside blockquotes rather than blocks in Zefyr at the moment. |
Same situation here . |
Same situation, will this get merged in? |
@ambrose-gladwell-sonocent there's a PR in Delta to support nested formatting - slab/delta#48 |
Also interested |
interested as well. |
Don't think project is active anymore. |
I have implemented the
_NotusMarkdownDecoder
but can not figure out how to nest blocks within block quotes - it is possible in Markdown, but does Notus have that capability? If so, how?