Feature/refactor request builder #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucmantovani
reviewed
Mar 5, 2024
delias-silva
reviewed
Mar 5, 2024
pkg/internal/httpclient/helper.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func checkReplaces(pathURL string) error { |
There was a problem hiding this comment.
Usando o package regexp essa função não é necessária:
const pathParamRegexp = regexp.MustCompile(`{[^{}]*}`)
matches := pathParamRegexp.FindAllString(pathURL, -1)
pkg/internal/httpclient/helper.go
Outdated
| pathURL := req.URL.Path | ||
|
|
||
| for k, v := range params { | ||
| pathParam := fmt.Sprintf("{%s}", k) |
There was a problem hiding this comment.
Só para conhecimento, Sprintf não tem uma boa performance.
strings.Join e usar + é mais performático. Como é uma concatenação bem simlpes acredito que não precisa usar Sprintf.
Suggested change
| pathParam := fmt.Sprintf("{%s}", k) | |
| pathParam := "{"+k+"}" |
lucmantovani
approved these changes
Mar 5, 2024
delias-silva
approved these changes
Mar 6, 2024
rhames07
approved these changes
Mar 6, 2024
delias-silva
approved these changes
Mar 7, 2024
rhames07
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes options from baseclient, options are not so useful in that case because our baseclient should not have other configurations. This PR merges baseclient content with httpclient already that in our cases they have similar purposes (build request before sent to the Requester implementation).