fix: update DefaultGenerationURL to correct path for CRDs #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: devhindo <[email protected]>
leecalcote
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so
meshery-istiowas having this error:and after some retracing I found that in
build/config.goline 68 the generated URL ishttps://raw.githubusercontent.com/istio/istio/[Version of istio]/manifests/charts/base/crds/crd-all.gen.yamlwhich is incorrect for the current version of istio is1.24.2and the URL is failing to retrieve Istio Custom Resource Definition (CRD) hereso after some digging into the istio issues and blogs I found this issue which mentions that changing
/crds/tofilesfixes the problem as shown (here)[https://raw.githubusercontent.com/istio/istio/1.24.2/manifests/charts/base/files/crd-all.gen.yaml]I found that any version before
istio v1.24is working with/crds/but forv1.24and after works with/files/but haven't found any official istio docs that states so