Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a function to find a BLE peripheral #5

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Add a function to find a BLE peripheral #5

merged 3 commits into from
Jan 23, 2024

Conversation

lukipuki
Copy link
Collaborator

No description provided.

ajmcquilkin
ajmcquilkin reviewed Jan 19, 2024
View reviewed changes
src/utils_internal.rs

/// Finds a BLE radio matching a given name and running meshtastic.
/// It searches for the 'MSH_SERVICE' running on the device.
async fn find_ble_radio(name: String) -> Result<Peripheral, Error> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we export this function currently? I'm not seeing it being made public

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have made this more clear. This function is not supposed to be exposed, it's the first step of the future build_ble_stream function, see the screenshot.
Screenshot_20240119_080445

I'm splitting the BLE support into smaller PRs, so that it's easier to review. Otherwise it would be too much at once IMO.

@lukipuki
Copy link
Collaborator Author

We should add sudo apt install libdbus-1-dev pkg-config to the ubuntu CI setup but I don't know where the CI config files are located.

@ajmcquilkin
Copy link
Member

We should add sudo apt install libdbus-1-dev pkg-config to the ubuntu CI setup but I don't know where the CI config files are located.

If you go into .github/workflows/testing.yml you can add a new step into the testing pipeline (which is what we're running on commit and PR): https://github.com/meshtastic/network-management-client/blob/f809520d02985daecb9ea04beaff19729eb7834e/.github/workflows/testing.yml#L32C7-L36C112

@ajmcquilkin
Copy link
Member

Updated testing flow to add required Ubuntu deps

@lukipuki
Copy link
Collaborator Author

Thanks @ajmcquilkin! I'm fine with merging now, though the MacOS CI has been stuck for 5 hours now and I'm unable to restart it.

@ajmcquilkin ajmcquilkin merged commit e77d168 into meshtastic:main Jan 23, 2024
3 checks passed
@lukipuki lukipuki deleted the ble-setup branch January 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajmcquilkin ajmcquilkin ajmcquilkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukipuki @ajmcquilkin