Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MacQA, a one-clickable app implementation to DocQA(DO_NOT_REVIEW, waiting for 0.1) #151

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

wukaixingxp
Copy link
Contributor

@wukaixingxp wukaixingxp commented Jan 10, 2025

What does this PR do?

This PR adds a one-clickable app implementation to existing DocQA example, where user can choose local provider like Ollama or cloud provider like together or fireworks to do RAG. It allows users to install the MacQA app into the Application folder from the MacQA.dmg file. This MacQA app leverages llama-stack new LlamaStackAsLibraryClient feature and make every agentic component in-line. This PR also explains the steps for building this app.

This PR is created on top of existing DocQA example and renamed the previous Docker pipeline as DockerQA.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@wukaixingxp wukaixingxp self-assigned this Jan 10, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 10, 2025
@HamidShojanazeri
Copy link

@wukaixingxp I wonder if there is a chance to consolidate app.py and MacA.py?

Co-authored-by: Hamid Shojanazeri <[email protected]>
@wukaixingxp
Copy link
Contributor Author

wukaixingxp commented Jan 13, 2025

@wukaixingxp I wonder if there is a chance to consolidate app.py and MacA.py?

Sure, there is a different behavior regarding how to launch Ollama between MacQA.py and app.py, maybe I can have a system env "USE_DOCKER" to control that.

Update on Jan 13: The merge has been completed in f610415. Please take a look

@wukaixingxp wukaixingxp changed the title Added MacQA, a one-clickable app implementation to DocQA Added MacQA, a one-clickable app implementation to DocQA(DO_NOT_REVIEW, waiting for 0.1) Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants