-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#432] Groq Provider tool call tweaks #811
Open
aidando73
wants to merge
1
commit into
meta-llama:main
Choose a base branch
from
aidando73:aidand-groq-tool-call-tweaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidando73
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic and
sixianyi0721
as code owners
January 17, 2025 22:08
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Jan 17, 2025
aidando73
force-pushed
the
aidand-groq-tool-call-tweaks
branch
from
January 17, 2025 23:16
3ceb004
to
0c4d4a4
Compare
aidando73
force-pushed
the
aidand-groq-tool-call-tweaks
branch
from
January 17, 2025 23:17
0c4d4a4
to
76e08cf
Compare
aidando73
commented
Jan 17, 2025
|
||
call_id: str | ||
tool_name: str | ||
arguments: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToolCall.arguments
must be a Dict, so we can't keep it within ToolCall
@json_schema_type
class ToolCall(BaseModel):
call_id: str
tool_name: Union[BuiltinTool, str]
arguments: Dict[str, RecursiveType]
aidando73
commented
Jan 17, 2025
and "Llama-3.2" in inference_model | ||
): | ||
# TODO(aidand): Remove this skip once Groq's tool calling for Llama3.2 works better | ||
pytest.skip("Groq's tool calling for Llama3.2 doesn't work very well") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up for @ashwinb's comments in #630
Test Plan
Environment
Unit tests
Integration tests
(One failure as expected from 3.2 3B - re: #630 (comment))
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?