Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[memory refactor][1/n] Rename Memory -> VectorIO, MemoryBanks -> VectorDBs #828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[memory refactor][1/n] Rename Memory -> VectorIO, MemoryBanks -> VectorDBs #828

wants to merge 2 commits into from

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Jan 19, 2025

See #827 for the broader design.

This is the first part:

  • delete other kinds of memory banks (keyvalue, keyword, graph) for now; we will introduce a keyvalue store API as part of this design but not use it in the RAG tool yet.
  • renaming of the APIs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 19, 2025
@ashwinb ashwinb linked an issue Jan 19, 2025 that may be closed by this pull request
Improve ergonomics for the builtin "memory" (RAG) tool #827
Open
ashwinb
ashwinb commented Jan 19, 2025
View reviewed changes
llama_stack/apis/vector_io/vector_io.py
@webmethod(route="/memory/insert", method="POST")
async def insert_documents(
@webmethod(route="/vector-io/insert", method="POST")
async def insert_chunks(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the important change to focus on. the input now is chunks not documents.

@ashwinb ashwinb force-pushed the memory_to_vector_io branch from 108f667 to 138003f Compare January 19, 2025 21:23
@ashwinb ashwinb removed a link to an issue Jan 19, 2025
Improve ergonomics for the builtin "memory" (RAG) tool #827
Open
@ashwinb ashwinb linked an issue Jan 19, 2025 that may be closed by this pull request
Improve ergonomics for the builtin "memory" (RAG) tool #827
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ergonomics for the builtin "memory" (RAG) tool
2 participants
@ashwinb @facebook-github-bot