Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

manifestlint: move from kubeval to kubeconform #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 4, 2023

kubeval is not maintained anymore, and suggest moving to kubeconform. Change manifestlint.sh to use kubeconform.

Pin kubeconform image with a version and a digest.

kubeval is not maintained anymore, and suggest moving to kubeconform.
Change manifestlint.sh to use kubeconform.

Pin kubeconform image with a version and a digest.
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ashughorla after the PR has been reviewed.
You can assign the PR to them by writing /assign @ashughorla in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Jan 4, 2023

Note: there is chicken/egg issue with project-infra change: metal3-io/project-infra#462

@metal3-io-bot
Copy link
Collaborator

@tuminoid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
manifestlint ee2f07a link true /test manifestlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tuminoid
Copy link
Member Author

tuminoid commented Jan 4, 2023

/hold

Holding to sync merging, due chicken/egg issue.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants