Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lutaml express liquid #169

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Add lutaml express liquid #169

merged 8 commits into from
Jan 24, 2025

Conversation

kwkwan
Copy link
Contributor

@kwkwan kwkwan commented Dec 6, 2024

Metanorma PR checklist

@kwkwan kwkwan linked an issue Dec 6, 2024 that may be closed by this pull request
Add lutaml_express_liquid to render EXPRESS liquid drops #167
Closed
@kwkwan
Copy link
Contributor Author

kwkwan commented Dec 6, 2024

At 0e3bfec, lutaml_express_liquid will process EXPRESS files as Liquid Drops models. lutaml and lutaml_express will becomes the aliases of lutaml_express_liquid and perform the same thing as lutaml_express_liquid. Therefore, when using lutaml-express-index, users do not need to change the name of macro from lutaml or lutaml_express to lutaml_express_liquid to process EXPRESS files as Liquid Drops models.

The old methods and codes to process EXPRESS files will be removed later. The option leveloffset will also be removed later.

@kwkwan
Copy link
Contributor Author

kwkwan commented Dec 6, 2024

This PR is still under development. Please do not merge this PR at this moment.

@kwkwan kwkwan force-pushed the add-lutaml-express-liquid branch from 026eaa2 to ebca295 Compare January 9, 2025 00:24
@kwkwan kwkwan force-pushed the add-lutaml-express-liquid branch from ebca295 to ff419a2 Compare January 24, 2025 04:27
@kwkwan kwkwan merged commit d71231d into main Jan 24, 2025
16 of 17 checks passed
@ronaldtse
Copy link
Contributor

@kwkwan there seems to be a merge conflict in the README. Also, I thought we wanted to just use "lutaml_express" rather than "lutaml_express_liquid". Could you help adjust? Thanks!

ronaldtse
ronaldtse reviewed Jan 24, 2025
View reviewed changes
README.adoc
[lutaml_express,example.exp,my_context]
=======
[lutaml_express_liquid,example.exp,my_context]
>>>>>>> accd8ee (Remove obsolete codes of macros "lutaml" and "lutaml_express")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict committed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lutaml_express_liquid to render EXPRESS liquid drops
2 participants
@kwkwan @ronaldtse