-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dots in identifiers #27
base: main
Are you sure you want to change the base?
Support dots in identifiers #27
Conversation
@tshemsedinov , fixed. While testing, found a bug with metatests. I'll create an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more test cases
@tshemsedinov , added a few and I have a question. Should we return an object in that case? metatests.test('Read deep non-table identifiers', async (test) => {
const sheet = new Sheet();
sheet.cells['item.price.usd'] = 100;
sheet.cells['item.price.uah'] = 200;
test.strictSame(sheet.values['item.price'], { usd: 100, uah: 200 });
test.end();
}); And I broke metatests again. That test case passed for some reason. And if we place any check after it, it will pass too. test.strictSame(sheet.values['item.price'], { usd: 100, uah: 200 }); // -> not fails
test.strictSame(1, 0) // -> obviously, should fail, but it isn't Created an issue metarhia/metatests#270 |
3d8950e
to
9573b72
Compare
#19
npm t
)npm run fmt
)Basic solution for current test case