Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm t
)npm run fmt
)This is a proposal to use the Abortable class proposed in metarhia/metautil#198 to manage any kind of abortable tasks.
Currently:
Abortable can:
abort()
method;resetTimeout()
method can reset the scheduled timeout to a different value when the task is already running.We can also check if the task is aborted by calling
aborted
getter and throw bythrowIfAborted()
This implementation utilizes
timeouts.request
from application/config/server.js to create transport-level timeouts (currently onlyHttpTransport
) and alsotimeout
that is optionally defined on user API endpoint. Abortable is created on user request and injected intoClient
as private member. Theaborted
andthrowIfAborted()
are public inClient
so they can be used on endpoint to check if the task is aborted and stop execution. Additionally,onAborted
handler can be implemented by the user.Here's an example:
This will be aborted as well by
Server.rpc()
(timeouts.request = 5000
):