Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadMscwCtm] Supporting selecting files to be read by regexp match #1423

Closed
wants to merge 10 commits into from

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Nov 25, 2024

Change Summary

Support providing a custom regular expression to the EMEP reader which can be used to select files instead of the Base_{freq}.nc` matching that is currently being used.

Currently works with concatenated files.

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (413f9b8) to head (db847b5).
Report is 16 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/mscw_ctm/reader.py 92.30% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1423      +/-   ##
============================================
+ Coverage     78.35%   78.57%   +0.22%     
============================================
  Files           137      137              
  Lines         20889    20893       +4     
============================================
+ Hits          16367    16417      +50     
+ Misses         4522     4476      -46     
Flag Coverage Δ
unittests 78.57% <92.30%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl self-assigned this Nov 25, 2024
@thorbjoernl thorbjoernl marked this pull request as ready for review November 25, 2024 13:13
pyaerocom/io/mscw_ctm/reader.py Outdated Show resolved Hide resolved
pyaerocom/io/mscw_ctm/reader.py Outdated Show resolved Hide resolved
pyaerocom/io/mscw_ctm/reader.py Outdated Show resolved Hide resolved
pyaerocom/io/mscw_ctm/reader.py Outdated Show resolved Hide resolved
@thorbjoernl
Copy link
Collaborator Author

Closing because changes are merged with #1425

@thorbjoernl thorbjoernl closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants