Fix modelmaps #1444
Merged
Fix modelmaps #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1444 +/- ##
============================================
- Coverage 78.50% 78.48% -0.02%
============================================
Files 139 139
Lines 21101 21106 +5
============================================
+ Hits 16565 16566 +1
- Misses 4536 4540 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I've might have fixed the bug now (needs more testing by charlie), but the original tests for modelmaps_engine are very bare-bones (that's why the bug was not caught), so I'll add more and better tests before reviewing |
lewisblake
approved these changes
Dec 13, 2024
pyaerocom/io/cams2_83/reader.py
Outdated
| @@ -219,7 +219,7 @@ def check_files(paths: list[Path]) -> list[Path]: | |||
|
|
|||
|
|
|||
| class ReadCAMS2_83(GriddedReader): | |||
| FREQ_CODES = dict(hour="hourly", day="daily", month="monthly", fullrun="yearly") | |||
| FREQ_CODES = dict(hour="hourly") # , day="daily", month="monthly", fullrun="yearly") | |||
|
Rerequesting my own review because tests failing now. Will review again once everything is fixed. |
magnusuMET
force-pushed
the
fix-modelmaps
branch
from
b655a38 to
e5d5dfe
Compare
|
Rebased on |
|
Fails due to #1469 |
… default choice of freq for same
…from MODELREADERS_USE_MAP_FREQ
magnusuMET
force-pushed
the
fix-modelmaps
branch
from
25c32f8 to
c9e08bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR tries to improve modelmaps_engine after some crashes by cams2_83
Related issue number
Fixes #1443
Checklist