-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model maps with ColocatedData objects #1470
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1470 +/- ##
============================================
+ Coverage 78.43% 78.47% +0.03%
============================================
Files 137 139 +2
Lines 20963 21113 +150
============================================
+ Hits 16442 16568 +126
- Misses 4521 4545 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Implements the functionality to make "model" maps from a ColocatedData object.
The way to do this is to
model_data_dir
in the model entry, ensuring that the path contains the model name at the end. (i.e.,"/lustre/storeB/users/lewisb/projects/CAMS2_82/coldata_testing2x2_180/ECMWF-OSUITE"
)coldata_dir
in the obs entry, ensuring that the model name does not appear at the end (i.e., "/lustre/storeB/users/lewisb/projects/CAMS2_82/coldata_testing2x2_180")add_model_maps=True
and optionally (depending on the resolution of the colocated data object)only_model_maps=True
pages = ("maps",)
if you only want to show mapsplot_types = {"ECMWF-OSUITE": "overlay", "MODIS-TERRA": "overlay"}
)Related issue number
Checklist