Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky CI test #1471

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Investigate flaky CI test #1471

merged 3 commits into from
Jan 7, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 7, 2025

Change Summary

There was a small issue with the endtime determination logic, which likely didn't surface locally because of the ordering of the processed files.

Related issue number

#1469

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (0eb6381) to head (d07f1a3).
Report is 7 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1471      +/-   ##
============================================
+ Coverage     78.49%   78.50%   +0.01%     
============================================
  Files           139      139              
  Lines         21090    21101      +11     
============================================
+ Hits          16554    16565      +11     
  Misses         4536     4536              
Flag Coverage Δ
unittests 78.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl requested a review from magnusuMET January 7, 2025 08:44
@thorbjoernl thorbjoernl marked this pull request as ready for review January 7, 2025 08:44
@magnusuMET magnusuMET linked an issue Jan 7, 2025 that may be closed by this pull request
@magnusuMET magnusuMET merged commit cb84c4c into main-dev Jan 7, 2025
8 checks passed
@magnusuMET magnusuMET deleted the debug-flaky-test branch January 7, 2025 09:27
@heikoklein heikoklein added this to the m2025-01 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test test_read_emep_multiple_dirs_hour_error
3 participants