fix: switch to clock_gettime(3) for macOS/iOS for monotonic clock
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where on M1 (and presumably M2/M3) hardware, the usage of mach_absolute_time() resulted in undermeasuring the passage of time when compared to std::time::Instant. Now we read from the monotonic clock (using clock_gettime, but conceptually the same as calling mach_continuous_time()) which properly tracks the passage of time regardless of device sleep, frequency, etc.
tabVersion
pushed a commit
to tabVersion/quanta
that referenced
this pull request
Oct 29, 2024
…etrics-rs#97) This fixes an issue where on M1 (and presumably M2/M3) hardware, the usage of mach_absolute_time() resulted in undermeasuring the passage of time when compared to std::time::Instant. Now we read from the monotonic clock (using clock_gettime, but conceptually the same as calling mach_continuous_time()) which properly tracks the passage of time regardless of device sleep, frequency, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where on M1 (and presumably M2/M3) hardware, the usage of
mach_absolute_time()resulted in undermeasuring the passage of time when compared tostd::time::Instant.Now we read from the monotonic clock (using
clock_gettime(CLOCK_MONOTONIC), but conceptually the same as callingmach_continuous_time()) which properly tracks the passage of time regardless of device sleep, frequency, etc.Fixes #96.