Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown formatting for adodbapi #2210

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 16, 2024

The adodbapi version of #2209

  • Used code blocks with language marker (which should add syntax highlighting depending on the viewer, and a copy button on GitHub)
  • Ran the files through Markdownlint
    • Which standardized spacing and bare links

CC @vernondcole

@vernondcole
Copy link
Collaborator

This look great, and thank you for all the work!
I have added two comments in-line. One is a broken link which should be excluded.
The second is also a broken link, but it has an update to a different Microsoft page, so we can just change the link.

@Avasam
Copy link
Collaborator Author

Avasam commented Mar 19, 2024

Hi @vernondcole Thanks for the review! But I don't see your comments
I suppose you are talking about https://asp101.com/articles/john/connstring/default.asp and http://www.microsoft.com/en-us/download/details.aspx?id=13255 . Although I don't know what's the new link.

adodbapi/quick_reference.md Outdated Show resolved Hide resolved
adodbapi/quick_reference.md Outdated Show resolved Hide resolved
@vernondcole
Copy link
Collaborator

vernondcole commented Mar 19, 2024 via email

@Avasam Avasam requested a review from vernondcole March 20, 2024 01:18
Copy link
Collaborator

@vernondcole vernondcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great. Merge at will.

@Avasam Avasam merged commit 493aba1 into mhammond:main Mar 25, 2024
27 checks passed
@Avasam Avasam deleted the improve-markdown-formatting-adodbapi branch March 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants