-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass sources prop to support multiple video qualities (fixes #67) #116
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@danmakenoise want to take a peek at this?
@zbuttram I'm good with it! Would you be willing to add a test for it before we merge? |
@danmakenoise Yeah, no problem. Would something in the Edit: Looks like I should add a check in |
@zbuttram Sounds good to me, thank you! |
Guys, will you be merging this anytime soon? Would really like this feature. |
@harsharora04 Sorry, I imagine that's kind of on me for putting the requested changes off for so long. Just finished it up so it should be ready to merge now. |
Thanks @zbuttram. |
Thanks, this is what i need. it worked well to me |
Sources can be set now, but are a bit buggy, I'm guessing it's because this wasn't merged? |
Allows the official way of adding multiple HD/SD qualities as seen here: https://support.jwplayer.com/articles/how-to-add-an-hd-quality-toggle
Also a resolution for #67
I have confirmed it works with a test build.