Skip to content

Commit

Permalink
Incorporate feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mar-v-in committed Feb 16, 2024
1 parent af54a19 commit f1c4a3a
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 53 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ package com.google.android.gms.panorama.internal;
import android.content.Intent;

interface IPanoramaCallbacks {
void getViewerIntent(int status, in Intent intent);
void onPanoramaResult(int statusCode, in Bundle statusExtras, int unknown, in Intent viewerIntent);
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ import android.os.Bundle;
import android.net.Uri;

interface IPanoramaService {
void loadPanoramaInfoAndGrantAccess(IPanoramaCallbacks callback, in Uri uri, in Bundle bundle, boolean needGrantReadUriPermissions) = 0;
void loadPanoramaInfo(IPanoramaCallbacks callback, in Uri uri, in Bundle bundle, boolean needGrantReadUriPermissions) = 0;
}
1 change: 0 additions & 1 deletion play-services-core/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,6 @@
<action android:name="com.google.android.gms.notifications.service.START" />
<action android:name="com.google.android.gms.ocr.service.internal.START" />
<action android:name="com.google.android.gms.ocr.service.START" />
<action android:name="com.google.android.gms.panorama.service.START" />
<action android:name="com.google.android.gms.payse.service.BIND" />
<action android:name="com.google.android.gms.people.contactssync.service.START" />
<action android:name="com.google.android.gms.photos.autobackup.service.START" />
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* SPDX-FileCopyrightText: 2023 microG Project Team
* SPDX-License-Identifier: Apache-2.0
*/
package org.microg.gms.panorama

import android.net.Uri
import android.os.Bundle
import android.util.Log
import com.google.android.gms.common.api.CommonStatusCodes
import com.google.android.gms.common.internal.GetServiceRequest
import com.google.android.gms.common.internal.IGmsCallbacks
import com.google.android.gms.panorama.internal.IPanoramaCallbacks
import com.google.android.gms.panorama.internal.IPanoramaService
import org.microg.gms.BaseService
import org.microg.gms.common.GmsService

class PanoramaService : BaseService("GmsPanoramaService", GmsService.PANORAMA) {
override fun handleServiceRequest(callback: IGmsCallbacks, request: GetServiceRequest, service: GmsService) {
callback.onPostInitComplete(CommonStatusCodes.SUCCESS, PanoramaServiceImpl().asBinder(), null)
}
}

class PanoramaServiceImpl : IPanoramaService.Stub() {
override fun loadPanoramaInfo(callback: IPanoramaCallbacks?, uri: Uri, bundle: Bundle, needGrantReadUriPermissions: Boolean) {
Log.d("GmsPanoramaService", "ERROR:PanoramaService not implement! Print by GMS...$uri bundle:$bundle")
}
}

0 comments on commit f1c4a3a

Please sign in to comment.