Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that Tasks&Jamboard&Fitbit App cannot log in with Google #2123

Closed
wants to merge 2 commits into from

Conversation

DaVinci9196
Copy link
Contributor

@DaVinci9196 DaVinci9196 commented Dec 19, 2023

1.Fix the problem that Tasks&Jamboard&Fitbit App cannot log in with Google
2.Declare CAR_SPEED permission

@DaVinci9196 DaVinci9196 changed the title Declare CAR_SPEED permission Fix the problem that Tasks&Jamboard&Fitbit App cannot log in with Google Jan 26, 2024
@@ -90,6 +90,11 @@
android:description="@string/perm_provision_description"
android:label="@string/perm_provision_label"
android:protectionLevel="privileged|signature" />
<permission
android:name="com.google.android.gms.permission.CAR_SPEED"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which app/issue is fixed by adding the CAR_SPEED permission? What about CAR_MILEAGE and CAR_FUEL permissions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the Google Maps location permission authorization pop-up window when connecting to Android Auto. The window still pops up after authorization.

@ale5000-git
Copy link
Member

ale5000-git commented Jan 29, 2024

  • Fitbit isn't a Google apps, also I never had any "login" problem with it.
  • Tasks correctly use android.permission.GET_ACCOUNTS.

The only needed one is Jamboard.

@ale5000-git
Copy link
Member

ale5000-git commented Jan 30, 2024

@mar-v-in

All car related permissions that I have found:

    <permission
        android:name="com.google.android.gms.permission.CAR"
        android:label="@string/perm_car_label"
        android:description="@string/perm_car_description"
        android:protectionLevel="signature" />
    <permission
        android:name="com.google.android.gms.permission.CAR_SPEED"
        android:label="@string/perm_car_speed_label"
        android:description="@string/perm_car_speed_description"
        android:permissionGroup="android.permission-group.LOCATION"
        android:protectionLevel="dangerous" />
    <permission
        android:name="com.google.android.gms.carsetup.DRIVING_MODE_MANAGER"
        android:protectionLevel="signature" />

    <permission-group
        android:name="com.google.android.gms.permission.CAR_INFORMATION"
        android:label="@string/perm_car_info_label"
        android:description="@string/perm_car_info_description"
        android:icon="@drawable/..." /> <!-- ToDO: Add icon -->
    <permission
        android:name="com.google.android.gms.permission.CAR_FUEL"
        android:label="@string/perm_car_fuel_label"
        android:description="@string/perm_car_fuel_description"
        android:permissionGroup="com.google.android.gms.permission.CAR_INFORMATION"
        android:protectionLevel="dangerous" />
    <permission
        android:name="com.google.android.gms.permission.CAR_MILEAGE"
        android:label="@string/perm_car_mileage_label"
        android:description="@string/perm_car_mileage_description"
        android:permissionGroup="com.google.android.gms.permission.CAR_INFORMATION"
        android:protectionLevel="dangerous" />
    <permission
        android:name="com.google.android.gms.permission.CAR_VENDOR_EXTENSION"
        android:label="@string/perm_car_vendor_extension_label"
        android:description="@string/perm_car_vendor_extension_description"
        android:permissionGroup="com.google.android.gms.permission.CAR_INFORMATION"
        android:protectionLevel="dangerous" />


    <string name="perm_car_label">Car Service</string>
    <string name="perm_car_description">Access to the car service.</string>
    <string name="perm_car_speed_label">Car speed</string>
    <string name="perm_car_speed_description">"Access your car's speed"</string>

    <string name="perm_car_info_label">Car information</string>
    <string name="perm_car_info_description">"Access your car's information"</string>
    <string name="perm_car_fuel_label">Car fuel level</string>
    <string name="perm_car_fuel_description">"Access your car's fuel level information"</string>
    <string name="perm_car_mileage_label">Car mileage</string>
    <string name="perm_car_mileage_description">"Access your car's mileage information"</string>
    <string name="perm_car_vendor_extension_label">Car vendor channel</string>
    <string name="perm_car_vendor_extension_description">"Access your car's vendor channel to exchange car-specific information"</string>

@ale5000-git
Copy link
Member

How already said Fitbit and Tasks doesn't need this change.

The other parts are superceded by #2214 and #2208.

@ale5000-git ale5000-git closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants