Add http-01 support to the Let's Encrypt mechanism. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the autocert.Manager is always created regardless of whether Let's Encrypt is being used or not I opted to always wrap the HTTP redirect handler with the autocert.Manager HTTPHandler. This means that port 80 will always be available to handle a Let's Encrypt challenge as well as do the redirect. This should get Let's Encrypt support functioning again since tls-sni-02 and tls-sni-01 were deprecated.
knightsc
commented
Aug 11, 2018
| url := "https://" + req.Host + req.URL.String() | ||
| http.Redirect(w, req, url, http.StatusMovedPermanently) | ||
| }), | ||
| Handler: m.HTTPHandler(http.HandlerFunc(redirect)), |
There was a problem hiding this comment.
I think I'll need to refactor this a little since currently this code will only run if redirectHTTPS is true and we might be using Let's Encrypt but not doing redirects in that case these changes wouldn't work.
There was a problem hiding this comment.
Added a fixup in 178158e. If redirectHTTPS is true or we've set the GetCertificate config which indicates we're using Let's Encrypt then we will start the http listener. Using the redirect methods in both cases should be fine because the autocert.HTTPHandler will do a redirect anyway if nil is passed in which is the other option we could do. I think this should correctly work now in all cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the autocert.Manager is always created regardless of whether
Let's Encrypt is being used or not I opted to always wrap the HTTP
redirect handler with the autocert.Manager HTTPHandler. This means
that port 80 will always be available to handle a Let's Encrypt challenge
as well as do the redirect. This should get Let's Encrypt support
functioning again since tls-sni-02 and tls-sni-01 were deprecated.
Fixes micromdm/micromdm#408
Testing this was a little bit of a pain but here's the process I followed.
sudo ./build/darwin/micromdm serve --server-url https://mydomainThe result was no errors like mentioned in micromdm/micromdm#408 and I could view the certificate from the http response and it was indeed one issued by lets encrypt.