-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document and add example using unmarshaler interface #41
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
package plist_test | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/groob/plist" | ||
) | ||
|
||
const data = `<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>typekey</key> | ||
<string>A</string> | ||
<key>typeAkey</key> | ||
<string>VALUE-A</string> | ||
</dict> | ||
</plist>` | ||
|
||
type TypeDecider struct { | ||
ActualType interface{} `plist:"-"` | ||
} | ||
|
||
type TypeA struct { | ||
TypeAKey string `plist:"typeAkey"` | ||
} | ||
|
||
type TypeB struct { | ||
TypeBKey string `plist:"typeBkey"` | ||
} | ||
|
||
func (t *TypeDecider) UnmarshalPlist(f func(interface{}) error) error { | ||
// stub struct for decoding a single key to tell which | ||
// specific type we should umarshal into | ||
typeKey := &struct { | ||
TypeKey string `plist:"typekey"` | ||
}{} | ||
if err := f(typeKey); err != nil { | ||
return err | ||
} | ||
|
||
// switch using the decoded value to determine the correct type | ||
switch typeKey.TypeKey { | ||
case "A": | ||
t.ActualType = new(TypeA) | ||
case "B": | ||
t.ActualType = new(TypeB) | ||
case "": | ||
return fmt.Errorf("empty typekey (or wrong input data)") | ||
default: | ||
return fmt.Errorf("unknown typekey: %s", typeKey.TypeKey) | ||
} | ||
|
||
// decode into the actual type | ||
return f(t.ActualType) | ||
} | ||
|
||
// Example_unmarshaler demonstrates using structs that use the Unmarshaler interface. | ||
func Example_unmarshaler() { | ||
decider := new(TypeDecider) | ||
if err := plist.Unmarshal([]byte(data), decider); err != nil { | ||
fmt.Println(err) | ||
return | ||
} | ||
|
||
typeA, ok := decider.ActualType.(*TypeA) | ||
if !ok { | ||
fmt.Println("actual type is not TypeA") | ||
return | ||
} | ||
|
||
fmt.Println(typeA.TypeAKey) | ||
// Output: VALUE-A | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is renamed ExampleUnmarshaler, it will be come an example on the interface instead of a package-level example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. That was my goal! I tried to find examples and docs of how to do that, but came up empty. Was that documented somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blog post is what I was going off of: https://go.dev/blog/examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what I read. I guess I didn't extend the function naming from the non-whole file example to the whole-file in my head. 🤷 Thanks!