Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document and add example using unmarshaler interface #41

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions decode.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ import (
// MarshalFunc is a function used to Unmarshal custom plist types.
type MarshalFunc func(interface{}) error

// Unmarshaler is the interface implemented by types that can unmarshal
// themselves from property list objects. The UnmarshalPlist method
// receives a function that may be called to unmarshal the original
// property list value into a field or variable.
//
// It is safe to call the unmarshal function more than once.
type Unmarshaler interface {
UnmarshalPlist(f func(interface{}) error) error
}
Expand Down
74 changes: 74 additions & 0 deletions example_unmarshaler_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package plist_test

import (
"fmt"

"github.com/groob/plist"
)

const data = `<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>typekey</key>
<string>A</string>
<key>typeAkey</key>
<string>VALUE-A</string>
</dict>
</plist>`

type TypeDecider struct {
ActualType interface{} `plist:"-"`
}

type TypeA struct {
TypeAKey string `plist:"typeAkey"`
}

type TypeB struct {
TypeBKey string `plist:"typeBkey"`
}

func (t *TypeDecider) UnmarshalPlist(f func(interface{}) error) error {
// stub struct for decoding a single key to tell which
// specific type we should umarshal into
typeKey := &struct {
TypeKey string `plist:"typekey"`
}{}
if err := f(typeKey); err != nil {
return err
}

// switch using the decoded value to determine the correct type
switch typeKey.TypeKey {
case "A":
t.ActualType = new(TypeA)
case "B":
t.ActualType = new(TypeB)
case "":
return fmt.Errorf("empty typekey (or wrong input data)")
default:
return fmt.Errorf("unknown typekey: %s", typeKey.TypeKey)
}

// decode into the actual type
return f(t.ActualType)
}

// Example_unmarshaler demonstrates using structs that use the Unmarshaler interface.
func Example_unmarshaler() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is renamed ExampleUnmarshaler, it will be come an example on the interface instead of a package-level example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. That was my goal! I tried to find examples and docs of how to do that, but came up empty. Was that documented somewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blog post is what I was going off of: https://go.dev/blog/examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I read. I guess I didn't extend the function naming from the non-whole file example to the whole-file in my head. 🤷 Thanks!

decider := new(TypeDecider)
if err := plist.Unmarshal([]byte(data), decider); err != nil {
fmt.Println(err)
return
}

typeA, ok := decider.ActualType.(*TypeA)
if !ok {
fmt.Println("actual type is not TypeA")
return
}

fmt.Println(typeA.TypeAKey)
// Output: VALUE-A
}
Loading