New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running PSScriptAnalyzer as local action. #1388

Merged

spetersenms merged 31 commits into microsoft:main from spetersenms:PSScriptAnalyzerAction

Jan 22, 2025

Contributor

spetersenms commented Jan 10, 2025

We are currently running PSScriptAnalyzer via the action in this repo: https://github.com/microsoft/psscriptanalyzer-action, however this has more settings and options than we need.
I recreated the action locally, and simplified it to fit our needs.

spetersenms added 5 commits

January 9, 2025 13:24


          Initial structure for local PSScriptAnalyzer action

cd7a0f8


          Removed unneeded parameters

e5b2dd5


          Pointing workflow to local PSScriptAnalyzer action

ddb6d57


          Adding verbose flag.

966cc03


          Updated readme.

dece92e

Copilot bot review requested due to automatic review settings

January 10, 2025 13:38

spetersenms requested a review from a team as a code owner

January 10, 2025 13:38

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

Actions/PSScriptAnalyzer/README.md Outdated Show resolved Hide resolved

spetersenms added 2 commits

January 10, 2025 14:47


          Fixed incorrect header label in PSScriptAnalyzer readme

f78399d


          Removed unused parameter from logic.

ec704ef

mazhelez reviewed

View reviewed changes

Actions/PSScriptAnalyzer/README.md Outdated Show resolved Hide resolved

mazhelez reviewed

View reviewed changes

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved


          Corrected PSScriptAnalyzer readme header.

c86cabc

mazhelez reviewed

View reviewed changes

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

mazhelez reviewed

View reviewed changes

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

spetersenms and others added 3 commits

January 10, 2025 14:25


          pre-commit

7a2bad9


          Adding retry logic

e6afb89


          Merge branch 'PSScriptAnalyzerAction' of github.com:spetersenms/AL-Go…

668c3db

… into PSScriptAnalyzerAction

Contributor Author

spetersenms commented Jan 13, 2025

@microsoft-github-policy-service agree company="Microsoft"

aholstrup1 reviewed

View reviewed changes

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

aholstrup1 reviewed

View reviewed changes

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

spetersenms added 2 commits

January 13, 2025 17:06


          Updated excludeRule param description

e559a9b


          Writing to GitHub errors instead of using Write-Error.

cc5028b

aholstrup1 previously approved these changes

View reviewed changes

mazhelez previously approved these changes

View reviewed changes

Collaborator

mazhelez left a comment

Great first addition! Left some comments, but otherwise, let's merge it!

Actions/PSScriptAnalyzer/README.md Outdated Show resolved Hide resolved

Actions/PSScriptAnalyzer/action.yml Outdated Show resolved Hide resolved

freddydk and others added 4 commits

January 16, 2025 10:44


          Merge branch 'main' into PSScriptAnalyzerAction

6180d64


          Merge branch 'main' into PSScriptAnalyzerAction

9aeb8f4


          Moving PS code to .ps1 file and renaming to RunPSScriptAnalyzer

a92b81c


          Merge branch 'PSScriptAnalyzerAction' of github.com:spetersenms/AL-Go…

5f86817

… into PSScriptAnalyzerAction

spetersenms dismissed mazhelez’s stale review via

5f86817

January 16, 2025 14:34

spetersenms dismissed aholstrup1’s stale review via

5f86817

January 16, 2025 14:34

spetersenms added 4 commits

January 16, 2025 15:35


          Pointing to renamed action

287833a


          pre-commit

8e07f28


          Fixed typo

cf930bb


          Switching default shell to pwsh

dbac2df

github-advanced-security bot found potential problems

View reviewed changes

Actions/RunPSScriptAnalyzer/RunPSScriptAnalyzer.ps1 Fixed Show fixed Hide fixed

Actions/RunPSScriptAnalyzer/RunPSScriptAnalyzer.ps1 Fixed Show fixed Hide fixed

spetersenms added 3 commits

January 16, 2025 16:07


          Changed default value for shell parameter to pwsh

e3131f7


          pre-commit

f338c42


          Parsing ExcludeRule param as list

bca645d

aholstrup1 previously approved these changes

View reviewed changes

Actions/RunPSScriptAnalyzer/RunPSScriptAnalyzer.ps1 Outdated Show resolved Hide resolved

mazhelez reviewed

View reviewed changes

Actions/RunPSScriptAnalyzer/RunPSScriptAnalyzer.ps1 Outdated Show resolved Hide resolved


          Changing type of excludeRule to string[]

f57d678

spetersenms dismissed aholstrup1’s stale review via

f57d678

January 17, 2025 13:32

aholstrup1 previously approved these changes

View reviewed changes


          changing recurse parameter to switch type.

e55aecc

spetersenms dismissed aholstrup1’s stale review via

e55aecc

January 17, 2025 14:44

mazhelez reviewed

View reviewed changes

Actions/RunPSScriptAnalyzer/RunPSScriptAnalyzer.ps1 Outdated Show resolved Hide resolved

spetersenms and others added 2 commits

January 20, 2025 14:11


          Corrected null check for excludeRule param

2dd2be3


          Merge branch 'main' into PSScriptAnalyzerAction

5a40fb5

aholstrup1 previously approved these changes

View reviewed changes

freddydk previously approved these changes

View reviewed changes

spetersenms added 2 commits

January 21, 2025 16:34


          Fixed typo in Recurse param.

2dc3be4


          Merge branch 'PSScriptAnalyzerAction' of github.com:spetersenms/AL-Go…

a4b8013

… into PSScriptAnalyzerAction

spetersenms dismissed stale reviews from freddydk and aholstrup1 via

a4b8013

January 21, 2025 15:35

mazhelez approved these changes

View reviewed changes

freddydk approved these changes

View reviewed changes


          Merge branch 'main' into PSScriptAnalyzerAction

d11a284

spetersenms merged commit 0a44b3d into microsoft:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet