Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PivotItem/SecuredByRole render and workspace cost reloading #3739

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix PivotItem/SecuredByRole render and workspace cost reloading #3739

merged 2 commits into from
Oct 12, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 12, 2023

Fixes #3738

What is being addressed

  • Cannot surround PivotItem by SecuredByRole element so using error message
  • Costs relead when roles update

@marrobi marrobi enabled auto-merge (squash) October 12, 2023 09:37
@marrobi marrobi requested a review from damoodamoo October 12, 2023 09:38
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 2cbd1f8.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Oct 12, 2023

/test-force-approve

UI Only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 2cbd1f8)

(in response to this comment from @marrobi)

damoodamoo
damoodamoo approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid fussy <Pivot> :)

@marrobi marrobi merged commit 1258f4b into microsoft:main Oct 12, 2023
10 checks passed
@marrobi marrobi deleted the marrobi/issue3738 branch October 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoodamoo damoodamoo damoodamoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nesting of PivotItems in SecuredByRole causes issues
2 participants
@marrobi @damoodamoo