This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Handle fc layer output shape when C is single dimension #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks like another good pull request, I added some comments. |
|
I cannot see the comments yet, will look as soon as you have finalized the CR. |
lovettchris
reviewed
May 7, 2019
| @@ -1373,9 +1375,17 @@ def get_attributes(self, attrs: Attributes): | |||
| if 'strides' in attrs: | |||
| self.strides = attrs['strides'] | |||
| attributes['stride'] = self.strides[0] | |||
| if len(self.strides) > 1: | |||
| for s in self.strides[1:]: | |||
| if s != self.strides[0]: | |||
There was a problem hiding this comment.
how about "all(y == x[0] for y in x[1:])"
|
I will submit another PR |
|
Ok, thanks. I suspect the right fix might be to add some reinterpretlayout nodes on whatever nodes is downstream of the fc layer that needs something that is not 1d. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also warn about non-symmetric padding and strides, until support is added.