-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine branch a & b are different in clone time #23485
Merged
jikim-msft
merged 10 commits into
microsoft:main
from
jikim-msft:revertibles/throw-in-clone
Jan 8, 2025
Merged
Determine branch a & b are different in clone time #23485
jikim-msft
merged 10 commits into
microsoft:main
from
jikim-msft:revertibles/throw-in-clone
Jan 8, 2025
+52
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Issues related to distributed data structures
area: dds: tree
base: main
PRs targeted against main branch
labels
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Co-authored-by: yann-achard-MS <[email protected]>
Co-authored-by: yann-achard-MS <[email protected]>
Co-authored-by: yann-achard-MS <[email protected]>
yann-achard-MS
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
27911
Related PR: #23424
Enhance
TreeCheckout.clone()
with Early Branch ValidationThis PR adds upfront validation in
TreeCheckout
'sclone()
method to verify that the target branch shares a common ancestry with the source branch before attempting to clone revertibles. This validation:revert()
toclone()
, giving developers earlier feedbackThe change is supported by new test cases that verify the behavior of cloned revertibles across related and unrelated branches.