[LTS] Disable coverage reports #23510
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvy86
approved these changes
Jan 8, 2025
|
I'm confused about the build errors, a recent PR of mine had to run those pipelines and they succeeded, e.g. here. |
Yeah. Strange. Seems really unlikely it's caused by this PR given that evidence + failing in steps unrelated to these changes (and in the build-client job that succeeded, installing build tools went just fine). I'll merge and keep an eye out for this I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code coverage has been reporting incorrect results on LTS for a while but we haven't noticed: most recent results show only various files in PropertyDDS as being covered, despite the configs intending to verify coverage from all of our tests.
More recently, the removal of various property DDS packages caused the coverage upload step to start failing.
We could invest in fixing this, but it seems low value as LTS basically only receives security + infrastructure patches at this point, and code coverage is not a particularly relevant metric.