Allow multiple package selection flags #23511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- build-tools/packages/build-cli/docs/release.md: Evaluated as low risk
- build-tools/packages/build-cli/docs/exec.md: Evaluated as low risk
- build-tools/packages/build-cli/docs/typetests.md: Evaluated as low risk
Comments suppressed due to low confidence (1)
build-tools/packages/build-cli/src/test/filter.test.ts:370
- Add more test cases to cover different combinations of selection flags to ensure comprehensive test coverage.
it("multiple selection flags", async () => {
| "Select only packages that have changed when compared to a base branch. Use the --branch option to specify a different base branch. Cannot be used with other options.", | ||
| exclusive: ["dir", "releaseGroup", "releaseGroupRoot", "all", "packages"], | ||
| "Select packages that have changed when compared to a base branch. Use the --branch option to specify a different base branch. Cannot be used --all.", | ||
| exclusive: ["all"], |
There was a problem hiding this comment.
The error message for the 'changed' flag is missing a word. It should be 'Cannot be used with --all.'
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow PackageCommands to take multiple package selection flags and union the results together.
This makes operations like tagging asserts in a combination of packages possible without extra filtering logic.
Reviewer Guidance
The review process is outlined on this wiki page.