Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileNet: Update QNN EP example #1563

Merged
merged 3 commits into from
Jan 22, 2025
Merged

MobileNet: Update QNN EP example #1563

merged 3 commits into from
Jan 22, 2025

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Jan 22, 2025

Describe your changes

MobileNet QNN EP example was outdated. QNN EP no longer requires x86 env for dev and arm env for inference. There is only one windows x86 package that can do both.

  • Removed mobilenet_qnn_ep.py launcher script since a workflow json is enough.
  • Added dynamic -> static shape step as a pass instead of during model download. This makes the static shape requirement clear to the user.
  • Simplified data config.
  • Download files uses command list instead of string to run subprocess. Otherwise, there are potential issues with paths being split incorrectly.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@jambayk jambayk merged commit da3b967 into main Jan 22, 2025
24 checks passed
@jambayk jambayk deleted the jambayk/qnn-example branch January 22, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants