Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use correct cache directory for file logging #1564

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tezheng
Copy link
Contributor

@tezheng tezheng commented Jan 23, 2025

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link
Contributor

@jambayk jambayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jambayk
Copy link
Contributor

jambayk commented Jan 23, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jambayk
Copy link
Contributor

jambayk commented Jan 23, 2025

Failing test not related to this PR. It has become flaky recently. Will rerun it once the other tests are done.

@jambayk jambayk merged commit 28beb3f into microsoft:main Jan 23, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants